brave / brave/adblock-rust

Investigate using upstream `url` parser

Open
#333 0 comments 0 reactions 0 assignees View on GitHub
dependencies
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

`adblock-rust`'s URL parsing is an in-tree fork of some files from the `rust-url` project.

According to https://github.com/brave/adblock-rust/commit/eed6eb001393475b9b491667b43cb268a8adae9b, it was done this way in order to slim down the full URL parser, likely for performance reasons. That being said, it's now a ~5 year old implementation that hasn't received any security updates or bugfixes.

If possible, I'd prefer to get this situation sorted out by using a well-audited upstream implementation, whether that is directly from `rust-url` or elsewhere.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the in-tree URL parser fork and the referenced rust-url commit eed6eb001393475b9b491667b43cb268a8adae9b. Compare current parsing behavior and dependencies with rust-url or another audited upstream implementation, including the performance rationale. Done means the project has a justified upstream-parser direction that addresses maintenance and security concerns.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.