brave / brave/adblock-rust

support AdGuard scriptlet syntax

Open
#324 1 comment 5 reactions 0 assignees View on GitHub
enhancement uBO-parity
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

AdGuard uses `#%#//scriptlet(...)` for scriptlet injection syntax, whereas uBO filter lists generally use `+js(...)`. AdGuard's syntax requires quoting, which is supported in adblock-rust as of v0.8.3, so it could now be supported as an additional syntax alias.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the parser and existing handling for uBO `+js(...)` scriptlet filters, then read how quoted arguments are represented since adblock-rust v0.8.3 supports them. Add the AdGuard `#%#//scriptlet(...)` form as an additional syntax alias and verify that representative quoted scriptlet filters are accepted without changing existing syntax behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.