brave / brave/adblock-rust

enforce values on network filter options when possible

Open
#315 0 comments 0 reactions 1 assignee Claimed by @antonok-edm View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

Parsing the following and then converting it to content blocking syntax should _not_ cause a panic:

```
example.com$domain
```

Right now the filter is parsed but the content blocking conversion fails due to the missing domains.

This filter should fail at the parsing stage, and more generally, adblock-rust should always forbid filters from parsing when they have options which require associated values or options which cannot accept associated values.

The content blocking conversion part also should not cause panics for malformed filters.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.