brave / brave/adblock-rust

Support removeparam regexes

Open
#246 4 comments 0 reactions 1 assignee Claimed by @antonok-edm View on GitHub
uBO-parity
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

`removeparam` regex rules are relatively uncommon, and should be avoided by filter list authors because of the performance implications of using regexes. However, in some cases they are unavoidable, and so they should be supported.

They were left out of [the original `removeparam` implementation](https://github.com/brave/adblock-rust/pull/235) in an attempt to get the majority of the feature released earlier. In particular, uBlock Origin's `removeparam` implementation requires [a special `no-op` feature](https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#_-aka-noop) to prevent ambiguity when parsing. It's also worth reviewing the regex features supported by JS regexes vs. Rust regexes to minimize compatibility differences.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.