brave / brave/adblock-rust

ruadlist doesn't work right with Brave's adblocker

Open
#238 10 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

Since Brave's adblocker announced it's compatible with UbO's filters, I used [RuAdList-uBO.txt](https://github.com/easylist/ruadlist/blob/master/RuAdList-uBO.txt) only to realize it doesn't support a filter including other filters like that. I ended up have to add each filter file of the ruadlist collection manually (so many of them!). It's somewhat worked, but still not as optimal as it is on UbO. On news.mail.ru there is still empty ad container boxes. These boxes should be removed (as they are on UbO). I'm always using dark mode, having a white box on a dark background make my eyes hurt. Please fix it.

Update: my guess is Brave's adblocker does not fully support all of UbO's features so filter lists like css-fixes-experimental.txt and js-fixes-experimental.txt doesn't work optimally, I might have to install Stylus and ViolenMonkey to use the corresponding fixes like when using with Adblock Plus as stated on the [easylist forum](https://forums.lanik.us/viewtopic.php?t=22512-%D0%BE-%D1%84%D0%B8%D0%BB%D1%8C%D1%82%D1%80%D0%B5-ru-adlist-%D0%B8-%D0%B4%D0%BE%D0%BF%D0%BE%D0%BB%D0%BD%D0%B5%D0%BD%D0%B8%D1%8F%D1%85). But, it shouldn't be the case! Brave's adblocker should be compatible with all UbO filters isn't it?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue on news.mail.ru with RuAdList-uBO.txt and the individual ruadlist files in Brave's adblocker. Compare the handling of filter inclusion and the css-fixes-experimental.txt and js-fixes-experimental.txt files with uBlock Origin. Done means the filter collection works as expected and the empty ad containers are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.