brandly / brandly/angular-youtube-embed

Memory Leak - Chrome

Open
#157 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
505
Forks
145
PR merge metrics
No merged PRs in 30d

Description

The player is leaking memory when the events bound to the Iframe are not destroyed properly.
To reproduce this issue in Chrome Version: 61.0.3163.100 (Official Build) (64-bit)

1.) Open http://brandly.github.io/angular-youtube-embed/#/advanced
2.) Take an initial heap snapshot in chrome devtools
3.) toggle the ng-if example on and off while waiting for the video to load.
4.) Take another heap snapshot.
5.) Repeat the process.

As seen below the heap size will consistently increase.

screen shot 2017-09-26 at 4 39 27 pm

The root cause appears to be the angular scope on the events being passed into the call to the YT Iframe API.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.