brandly / brandly/Lax

Channel joins with 0 members when not allowed to join

Open
#98 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
137
Forks
23
PR merge metrics
No merged PRs in 30d

Description

If you join a channel while not identified, or you need to be invited, such as joining `#reddit` on `chat.freenode.net`, the room will "open" with 0 people, and you can even "chat", but error messages will be sent to `chat.freenode.net`'s main channel:

![image](https://user-images.githubusercontent.com/8848080/92440462-c8be5b80-f169-11ea-9e49-7505541ce8dc.png)

![image](https://user-images.githubusercontent.com/8848080/92440553-ee4b6500-f169-11ea-938c-c35eb5c970c5.png)

I don't know if this is a bug or not, I am pretty new to IRC. However, it is unintuitive. I would have expected the room to not open, with an error message dialog or something popping up. If nothing else, it would be nice to have a new message indicator on the `chat.freenode.net` label which would alert me to the server trying to tell me this information. On that note, it would help if `chat.freenode.net` was more apparently clickable -- I only learned that I could click on it by mistake.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the IRC join flow for a channel that requires identification or an invitation, such as #reddit on chat.freenode.net. Trace how the client handles the server's join error and the chat.freenode.net server label; the work is done when denied joins do not open a misleading usable room and the server's error is clearly surfaced.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, javascript, react, redux
Domain
desktop, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.