bramus / bramus/mixed-content-scan

Check for php_sapi_name should be adapted to new PHP versions

Open
#70 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
516
Forks
50
PR merge metrics
No merged PRs in 30d

Description

In my environment (PHP 7.1.9 cgi-fcgi) `php_sapi_name()` returns `fpm-fcgi`. So in my opinion the check for `cli` on line 14 should be adapted (maybe so it checks if `cli` is contained within `php_sapi_name()`).

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the check on line 14 and trace how php_sapi_name() is used. Reproduce or compare the reported PHP 7.1.9 cgi-fcgi environment with the expected CLI behavior, then define the supported check and verify that the script still distinguishes the intended runtime correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.