bramus / bramus/github-toggle-chrome-extension

Improvement: Use declarativeContent to do domain matching

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
needs investigation
Dominant language
JavaScript
Stars
4
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Older versions of the `pageaction_by_url` sample used [simple `.indexOf` matching](https://github.com/neopunisher/Chrome-Developer-Samples/blob/master/examples/api/pageAction/pageaction_by_url/background.js) to see whether a domain/URL matches or not. This plugin basically does the same.

Newer versions of the `pageaction_by_url` sample however [seem to use](https://chromium.googlesource.com/chromium/src/+/master/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/background.js) something named [`declarativeContent`](https://developer.chrome.com/extensions/declarativeContent) for its URL matching.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.