bramp / bramp/ffmpeg-cli-wrapper

Handle failures during progress parsing more gracefully

Open
#333 2 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Java
Stars
1.9k
Forks
424
Avg merge
5h 35m
Merged PRs (30d)
2

Description

I propose an option that allows progress parsing failures to be ignored. This way progress parsing can continue in the event of a one-time error that would have otherwise interrupted the parsing thread.

In #302 the progress parsing fails because of an unexpected input ("N/A" instead of a formatted timestamp) in the first progress event. Although #315 fixes this, there can arise other circumstances where parsing can fail. I propose a general solution, to allow these failures to be ignored altogether. In most scenarios the consumer doesn't care if every once in a while an event gets dropped as long as they get notified of the overall progress.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.