brainly / brainly/style-guide

Make it easier to export spinner and loading button to design tool (sketch)

Open
#2,079 0 comments 0 reactions 0 assignees View on GitHub
Type: Enhancement
Dominant language
TypeScript
Stars
165
Forks
31
PR merge metrics
No merged PRs in 30d

Description

Currently our spinner is created entirely in CSS (using `border-radius` technique). This is completely fine and performant solution. It has a flaw though in the context of brainly process. It makes exporting component from code to design tool particular hard task. We would need to implement special converter to handle this kind of css visuals (and I would say it would be really difficult considering you can create basically any image in css).

![image](https://user-images.githubusercontent.com/8572321/125404947-7ec08a80-e3b7-11eb-9e08-cc637322b587.png)

Proposed solution is to use SVG to represent spinner element.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.