bpfman / bpfman/bpfman-operator

Do we need to do more robust validation of programs and links?

Open
#396 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
38
Forks
27
PR merge metrics
No merged PRs in 30d

Description

The current code validates that that program and link IDs have been saved in the state CRDs and that bpfman knows about them.

The previous code would also check that all the data in the program+link matched what is intended. A better option would be to make load and attach operations idempotent (see: https://github.com/bpfman/bpfman-operator/issues/395).

It would currently be a bug if the program or link ID didn't match what we expected, so that shouldn't happen. However, if we don't do #395 it wouldn't hurt to make the check more robust just in case. If we do #395, bpfman would essentially do this for us so it wouldn't be needed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the load and attach operations that validate program and link IDs against state CRDs, then review the related idempotency proposal in issue #395. Determine whether #395 will make the extra validation unnecessary; done should be a decided approach with checks covering the intended program and link data if validation remains required.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.