bp / bp/resqpy

Progressively enable meaningful type checking by setting check_untyped_defs = true

Open
#910 0 comments 0 reactions 1 assignee Claimed by @connortann View on GitHub
good first issue
Dominant language
Python
Stars
67
Forks
18
Avg merge
2h 26m
Merged PRs (30d)
1

Description

Although mypy runs on the whole code base, most of the library code is not meaningfully checked, as in the current configuration untyped functions are ignored.

A first step could be to include in the env type stubs for 3rd party libs like pandas, lxml, scipy, for more accurate checks.

Over time we could opt-in certain modules to more meaningful type checking with e.g.:

```toml
# pyproject.toml
[[tool.mypy.overrides]]
module = [
"resqpy.crs",
"resqpy.time_series._any_time_series",
# add here as each is cleaned
]
check_untyped_defs = true
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.