bp / bp/ResSimpy

Add abstract decorators to properties and methods on the base classes.

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Python
Stars
23
Forks
8
Avg merge
16d 4h
Merged PRs (30d)
1

Description

Add the `@abstractmethod` decorator to all methods expected to be inherited on the derived classes, as well as below the `@property` decorator for all properties that should be implemented by all derived classes. A lot of the examples that require this change can be found by searching for `raise NotImplementedError("Implement this in the derived class")`, plenty of which can be found in `Wells.py`.
Ensure `@property` is above `@abstractmethod` for abstract properties.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.