bp / bp/ResSimpy

Nexus: Adding a completion to a Wellspec file with no Time card present fails to create a new one

Open
#163 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
Python
Stars
23
Forks
8
Avg merge
16d 4h
Merged PRs (30d)
1

Description

If add_completion is called on a wellspec file that doesn't contain any time cards, the new completion will be added to the same table as any existing completions for that well.

Expected behaviour: A new time card is added, as well as a new completion table, which the new completion is added to.

I have added a test to the branch `fix_add_completion_no_time_card` that fails due to this to help explain the issue and assist with fixing it. Please feel free to add other test cases in, however.

Contributor guide

Open the contributing guide

Research direction

Start with the add_completion entry point and inspect the failing test on the fix_add_completion_no_time_card branch. Reproduce the case using a Wellspec file with no time cards, then verify that a new time card and completion table are created and the completion is added to that table.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.