box / box/viewer.js

What is the crocodoc-subpx-fix for?

Open
#228 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
333
Forks
98
PR merge metrics
No merged PRs in 30d

Description

Namely, [this line](https://github.com/box/viewer.js/blob/master/src/css/viewer.css#L214).

The reason that I'm asking is because the zoom/transform combo happens in IE11 before the width: 1000% is calculated, resulting in an element that's 10x as wide as it's supposed to be. Now custom page content which is centered appears outside of the viewport.

I'd like to override the class to remove these values, but I don't want to remove any functionality they might have brought. What was the rationale behind scaling everything down 10x and zooming in 10x again?

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the crocodoc-subpx-fix rule at src/css/viewer.css:214 and reproduce the IE11 zoom/transform behavior described in the issue. Trace the rule's history or related viewer rendering code to identify its rationale, then document whether the values can be overridden without losing functionality and what the expected centered-content behavior is.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.