box / box/viewer.js

IE crashes when we load SVG assets

Open
#160 12 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
333
Forks
98
PR merge metrics
No merged PRs in 30d

Description

![viewer js error](https://cloud.githubusercontent.com/assets/9942633/5719727/0842a188-9b41-11e4-8589-20234e59ec0b.PNG)

Got this error in Internet explorer 11 (running on laptop with i5 processor, 4gb ram) . I was loading **only** svg assets from https://www.dropbox.com/sh/9s1xvbsnukx6u70/AAC3lAt_9xkiTfcPkwGM8Jfba?dl=0 .

``` javascript
viewer = Crocodoc.createViewer(element, {
url: magazinePath,
layout: Crocodoc.LAYOUT_VERTICAL_SINGLE_COLUMN,
enableTextSelection: true,
enableDragging: false,
useWindowAsViewport: true
});
viewer.load();
scope.currentPage = 1;

viewer.on('ready', function (event) {
scope.$parent.viewerNumPages = event.data.numPages;
});

viewer.on('pagefocus', function(page) {
scope.$apply(function() {
scope.$parent.viewerCurrentPage = page.data.page;
});
});
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the crash in Internet Explorer 11 with the SVG assets from the linked Dropbox folder and the supplied Crocodoc.createViewer configuration. Start at the createViewer and viewer.load entry points, then trace the error shown in the attached screenshot. Done means the SVG-only document loads without crashing in IE11 and the behavior is covered by an appropriate regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.