box / box/box-windows-sdk-v2

FoldersManager.GetTrashItemsAsync() method needs parameter for sort and direction

Open
#648 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
183
Forks
160
Avg merge
10h 44m
Merged PRs (30d)
15

Description

- [X] I have checked that the [SDK documentation][sdk-docs] and [API documentation][api-docs] doesn't solve my issue

### Description of the Issue
The FoldersManager.GetTrashItemsAsync() method includes a handful of parameters but doesn't include 'sort' and 'direction' which is supported in the 'List trashed items' API documentation here.
https://developer.box.com/reference/get-folders-trash-items/

### Versions Used
.NET SDK: Box.V2.Core 3.22.0

### Steps to Reproduce
//Try to add a parameter beyond those defined in BoxFoldersManager.cs
trashedItems = await boxClient.FoldersManager.GetTrashItemsAsync(folderLimit, folderOffset, itemFields, false, sort: date);

### Error Message, Including Stack Trace
CS0103 The name 'date' does not exist in the current context

It would be very helpful to have these additional parameters when working with trash items.

Thank you

[sdk-docs]: ./README.md
[api-docs]: https://developer.box.com/docs

Contributor guide

Open the contributing guide

Research direction

Start in BoxFoldersManager.cs and compare GetTrashItemsAsync() with the Box API's List trashed items documentation. Confirm how the existing parameters are assembled, then add support for the documented sort and direction parameters. Done means callers can pass both options and the request matches the API behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.