box / box/box-ui-elements

Replace @hapi/address with a browser-friendly util

Open
#1,915 0 comments 0 reactions 0 assignees View on GitHub
chore
Dominant language
TypeScript
Stars
551
Forks
351
Avg merge
5d 9h
Merged PRs (30d)
31

Description

**Environment:**
- Browser: IE11 and Edge

Since `@hapi` is explicitly made for Node and not browsers, it does not consider using newer objects such as `TextEncoder` as breaking changes. This caused a regression in `@hapi/address@2.1.2` where IE11/Edge breaks even though our dependency declares support for `^2.0.0`. We're solving this by pinning `@hapi/address` to `2.1.1`, the last known version that does not have the regression, but to future proof us against changes like this in the future, we should opt for a browser-friendly module or roll our own.

Related: https://github.com/hapijs/joi/issues/2230

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.