box / box/box-android-sdk

Release `4.2.3` still includes Android Support Library Annotations in POM

Open
#432 2 comments 0 reactions 2 assignees Claimed by @sujaygarlanka View on GitHub
bug
Dominant language
Java
Stars
64
Forks
66
PR merge metrics
No merged PRs in 30d

Description

- [x] I have checked that the [SDK documentation][sdk-docs] doesn't solve my issue.
- [x] I have checked that the [API documentation][api-docs] doesn't solve my issue.
- [x] I have searched the [Box Developer Forums][dev-forums] and my issue isn't already reported (or if it has been reported, I have attached a link to it, for reference).
- [x] I have searched [Issues in this repo][github-repo] and my issue isn't already reported.

### Description of the Issue
This repo has already been completely migrated to AndroidX, however, [the artifact for release `4.2.3`](https://mvnrepository.com/artifact/com.box/box-android-sdk/4.2.3) still includes the Android Support Library Annotations as a dependency [in the POM](https://repo1.maven.org/maven2/com/box/box-android-sdk/4.2.3/box-android-sdk-4.2.3.pom). This causes the Android Support Library Annotations to be included as a transitive dependency for any projects that use the Box SDK (which prevents disabling the Jetifier).

### Steps to Reproduce
1. Add `implementation 'com.box:box-android-sdk:4.2.3'` to a sample project that uses only AndroidX dependencies.
2. Add [Can I drop Jetifier?](https://github.com/plnice/can-i-drop-jetifier) to the sample project.
3. Run `./gradlew -Pandroid.enableJetifier=false canIDropJetifier`

### Expected Behavior
This should output `No dependencies on old artifacts! Safe to drop Jetifier.`

### Error Message
Instead this outputs:
```
Cannot drop Jetifier due to following external dependencies:

* com.box:box-android-sdk:4.2.3
\-- com.android.support:support-annotations:26.1.0
```

### Versions Used
Android SDK: 29
Android: 10

[sdk-docs]: ./doc
[api-docs]: https://developer.box.com/docs
[dev-forums]: https://community.box.com/t5/Platform-and-Development-Forum/bd-p/DeveloperForum
[github-repo]: https://github.com/box/box-java-sdk/search?type=Issues

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.