bountysource / bountysource/core

Trying to reset a password with an expired reset token should fail before asking user for new password

Open
#1,356 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
643
Forks
199
PR merge metrics
No merged PRs in 30d

Description

# Steps to Reproduce

1. Follow forgot password link
2. Get email with reset password link
3. Wait for 3 days
4. Follow link within the email
5. Fill out new password
6. Click submit

You will see this message:

screen shot 2018-09-24 at 11 40 32 am

# Expected

I would expect the system to tell me right away that the "Reset code is not valid" before asking me to submit a new password.

# Actual

The system allows me to send a password reset form. It is a waste of time. I would expect the error message right after step 4 (when I initially get to this page: https://www.bountysource.com/signin/reset)

# End goal

Improve usability and provide a better user experience.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reset flow at https://www.bountysource.com/signin/reset with a token older than three days, then trace where the token is checked and where the new-password form is presented. Done means an expired token is rejected immediately after opening the reset link, before the user is asked to enter or submit a password.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.