bottlerocket-os / bottlerocket-os/twoliter

`cargo deny` doesn't run for twoliter build-kit

Open
#526 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
34
Forks
43
Avg merge
11h 13m
Merged PRs (30d)
16

Description

**What happened**

While playing around with the Settings SDK, I noticed that `twoliter build-kit` [doesn't run] the `check-licenses` task that [runs] for the `build` task. I noticed this because I was using two different versions of the settings SDK (mine and default upstream), and I saw that the kit built successfully whereas the AMI failed to build due to the double declaration of the dependency.

[doesn't run]: https://github.com/bottlerocket-os/twoliter/blob/8ccdb9f9a1dd113721e4ca268e85a4e7d1d15c7a/twoliter/embedded/Makefile.toml#L894
[runs]: https://github.com/bottlerocket-os/twoliter/blob/8ccdb9f9a1dd113721e4ca268e85a4e7d1d15c7a/twoliter/embedded/Makefile.toml#L893

Contributor guide

Open the contributing guide

Research direction

Read twoliter/embedded/Makefile.toml around the linked build and build-kit task definitions at lines 893-894, and compare whether check-licenses is invoked by both. Done means the build-kit path runs check-licenses and catches the duplicate dependency declaration described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.