bottlerocket-os / bottlerocket-os/twoliter

`cargo make ami` does not use environment variable `PUBLISH_AMI_NAME`

Open
#507 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
34
Forks
43
Avg merge
11h 13m
Merged PRs (30d)
16

Description

**Platform I'm building on:**

AWS aarch64

**What I expected to happen:**

While creating and registering an AMI, I ran the make AMI command.

```
cargo make ami -e PUBLISH_AMI_NAME=testing_k8s
```

I expected it to register the AMI, with the name: `testing_k8s`. This is also specified here: https://github.com/bottlerocket-os/bottlerocket/blob/develop/PUBLISHING-AWS.md?plain=1#L28

**What actually happened:**

But it looks like it ignored the provided variable `PUBLISH_AMI_NAME` and instead registered the AMI with name `bottlerocket-aws-k8s-1.24-aarch64-v1.21.0-REDACTED-dirty`. It should *not* ignore this variable and it should register the AMI with the provided variable name.

**How to reproduce the problem:**

Run the default build of bottlerocket
```
cargo make
```
and then create/register an AMI.
```
cargo make ami -e PUBLISH_AMI_NAME=testing_k8s
```

Contributor guide

Open the contributing guide

Research direction

Start with the `cargo make ami` command and compare its handling of `PUBLISH_AMI_NAME` with the usage described in `PUBLISHING-AWS.md`. Reproduce the command using `-e PUBLISH_AMI_NAME=testing_k8s`; done means the registered AMI uses `testing_k8s` instead of the generated default name.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, rust
Domain
build-system, cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.