bottlerocket-os / bottlerocket-os/twoliter

feature request: add a task that checks if first-party patches are included in spec files

Open
#468 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
34
Forks
45
Avg merge
11h 13m
Merged PRs (30d)
16

Description

**What I'd like**

packages that are built via `twoliter` for kits and variants often include patch files in tree, applied in the package spec definition.

Implement a `twoliter` check, `check-included-patches`, to confirm that firsty party `*.patch` files in a package directory are referenced in `PatchNNN: NNN-fix.patch` lines in the package's spec.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the existing twoliter check command implementations and identify how package directories and spec definitions are discovered. Implement the check-included-patches command to compare first-party *.patch files with PatchNNN references, then run the relevant check tests or the twoliter check test suite and verify that unreferenced or missing patches are reported.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.