bottlerocket-os / bottlerocket-os/twoliter

Implement a twoliter lint command to do what tasks.check-shell used to

Open
#42 2 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
34
Forks
43
Avg merge
11h 13m
Merged PRs (30d)
16

Description

This does what it is supposed when a user, i.e. the Bottlerocket project, calls it. But it used to check rpm2img and other scripts in the tools dir, but now it doesn't because it's not being called in Twoliter's CI. Add these checks to Twoliter's CI.

https://github.com/bottlerocket-os/twoliter/blob/bc65277a733f5c1ff8dfac69e0a27e6197c258a6/twoliter/embedded/Makefile.toml#L500

Contributor guide

Open the contributing guide

Research direction

Start with the referenced twoliter/embedded/Makefile.toml entry around line 500, then inspect the existing tasks.check-shell behavior and the tools directory scripts such as rpm2img. Trace how Twoliter's CI invokes linting. Done means the new twoliter lint command performs those checks and Twoliter's CI runs them.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.