bottlerocket-os / bottlerocket-os/twoliter

Remove env var processing from secrets_args

Open
#237 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
34
Forks
43
Avg merge
11h 13m
Merged PRs (30d)
16

Description

Inside of the [secrets_args](https://github.com/bottlerocket-os/twoliter/blob/f6eba80d0568091daefeb3733e727fc239ddff20/tools/buildsys/src/builder.rs#L688) function, we read several variables from the environment instead of the centralized arguments in `args.rs`. As an optimization, we should remove these and leave the argument collection to `args.rs`.

Contributor guide

Open the contributing guide

Research direction

Start in tools/buildsys/src/builder.rs at the secrets_args function referenced by the issue, then compare its environment-variable handling with the centralized argument collection in args.rs. Done means secrets_args no longer processes those environment variables and the argument collection remains centralized in args.rs.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.