bottlerocket-os / bottlerocket-os/bottlerocket-test-system

testsys-launcher: CFN parameter for instance type that is launched

Open
#827 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
18
Forks
27
PR merge metrics
No merged PRs in 30d

Description

It'd be great to provide a CFN parameter for the _type_ of instance that is launched in the nodegroup:

```go
testsysNodegroupInstanceType := awscdk.NewCfnParameter(stack, jsii.String("TestsysNodegroupInstanceType"), &awscdk.CfnParameterProps{
Type: jsii.String("String"),
Description: jsii.String("The x86 instance type to launch in the nodegroup"),
Default: jsii.String("m5.xlarge"),
})
```

But this is currently blocked on https://github.com/aws/aws-cdk/issues/25615

We could drop in a env variable at "synth-time" to get it in but it'd be great if there was just a single interface to drop these in

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the testsys-launcher nodegroup synthesis and the linked AWS CDK issue 25615. Determine whether the proposed TestsysNodegroupInstanceType parameter can be passed through the existing interface or whether the upstream blocker remains. Done means the launched nodegroup instance type is configurable through one interface, with m5.xlarge as the default.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, go
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.