bottlerocket-os / bottlerocket-os/bottlerocket-test-system

model: consider removing agent.name

Open
#306 0 comments 0 reactions 0 assignees View on GitHub
model priority/mid
Dominant language
Rust
Stars
18
Forks
27
PR merge metrics
No merged PRs in 30d

Description

The name here should basically match the name of the crate that produced the image. I commented on this early. The `name` field of the `Agent` model is poorly conceived. I thought of it as a name for the program, e.g.
- ecs-test-agent
- sonobuoy-test-agent
- migration-test-agent
- eks-resource-agent

I don't think we are using it for anything at all and we should probably remove it from the model since it's a source of confusion that adds no value.

_Originally posted by @webern in https://github.com/bottlerocket-os/bottlerocket-test-system/pull/297#discussion_r808572177_

Contributor guide

Open the contributing guide

Research direction

Start by locating the Agent model and searching the repository for uses of its name field. Confirm whether the field is unused, then update the affected model references and tests; done means the Agent model no longer exposes name and the test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.