bosnet / bosnet/sebak

Do not echo back on successful POST on api/transaction

Open
#648 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
44
Forks
12
PR merge metrics
No merged PRs in 30d

Description

At the moment, after a transaction is successfully POSTed, we just echo it back [with the hash](https://github.com/bosnet/sebak/blob/aa4ff033fed5c18a2e36982b8b7f93c3e7553030/lib/node/runner/api/transaction_post.go#L50-L52).
This is not actually useful to anyone: the caller can just save the transaction, and since the tx is signed, [s]he already know the hash.

Contributor guide

Open the contributing guide

Research direction

Start in lib/node/runner/api/transaction_post.go at the linked response-handling lines 50–52. Trace the successful POST path and confirm the intended behavior for a signed transaction; done means a successful POST no longer echoes the transaction and hash back to the caller.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, blockchain
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.