borgbackup / borgbackup/borg

borg2: consider dropping --exclude and --exclude-from

Open
#8,539 5 comments 0 reactions 0 assignees View on GitHub
cmd: create patterns
Dominant language
Python
Stars
13.7k
Forks
875
Avg merge
11h 15m
Merged PRs (30d)
192

Description

In borg 1.4 there are two distinct sets of options that can be used to define excludes:
`--exclude` and `--exclude-from`
AND
`--pattern` or `--patterns-from`

To cite borg documentation:
> A more general and easier to use way to define filename matching patterns exists with the --pattern and --patterns-from options. Using these, one may specify the backup roots, default pattern styles and patterns for inclusion and exclusion.

From a user's point of view:
--exclude style seems to provide only a subset of --pattern style.
Both (--exclude and --pattern) make use of patterns - but have different defaults - which can be confusing.
It is not clear why --exclude style exists.

I just wondered if borg2 would provide a good opportunity to drop --exclude and --exclude-from and to only use
--pattern and --patterns-from, in the future. But maybe I just miss important differences between both set of options.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.