borgbackup / borgbackup/borg

windows: handle inherited ACEs in ACLs

Open
#1,341 2 comments 0 reactions 0 assignees View on GitHub
os: windows
Dominant language
Python
Stars
13.7k
Forks
875
Avg merge
11h 15m
Merged PRs (30d)
192

Description

'Inherit' access-control entries (ACEs) are currently not handled. They should be, though, because this often results in permissions missing from items.

There are multiple ways to deal with this:
- Calculate or retrieve the "effective" ACL with only EXPLICIT_ACCESS ACEs.

This has the advantage that no further processing has to be done when extracting.
The disadvantage is that one inherited ACE is replicated across all files/directories it affects, even after extraction.
- Create EXPLICIT_ACCESS ACEs in root items from their "effective ACL"

Advantage: ACLs will be inherited inside the directory structure, even after extraction.

Disadvantage: More complex than option 1, and also requires special treatment when extracting only subset of a full archive

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.