boot-clj / boot-clj/boot

Notify does not notifies on :failure with boot-test

Open
#513 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
1.7k
Forks
178
PR merge metrics
No merged PRs in 30d

Description

It looks like, by looking at the code, a failure is only considered when an exception is thrown and indeed [boot-test](https://github.com/adzerk-oss/boot-test/blob/master/src/adzerk/boot_test.clj#L152) throws.

However I cannot hear the failure sound playing.

EDIT: I am on `2.6.0`, trying on `2.7.0-rc1`

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failure notification with boot-test, using the linked source at src/adzerk/boot_test.clj around line 152 and the reported Boot versions 2.6.0 and 2.7.0-rc1. Trace how the thrown exception reaches the :failure notification and verify that the failure sound plays when the issue is fixed.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.