boot-clj / boot-clj/boot

Consider Reader Support For File Objects

Open
#250 1 comment 0 reactions 0 assignees View on GitHub
Enhancement help wanted
Dominant language
Clojure
Stars
1.7k
Forks
178
PR merge metrics
No merged PRs in 30d

Description

were it not for the File object on :dir in the TmpFile record, tmpfiles could be passed directly into pods.

``` clojure
#boot.tmpdir.TmpFile{:dir #object[java.io.File 0x5577160d[/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s], :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}
```

storing the directory as a string instead makes this possible:

``` clojure
(defn marshall-tmpfile [tmpfile] (update tmpfile :dir #(.getPath %)))

#boot.tmpdir.TmpFile{:dir "/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s", :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}

```

it would be an improvement, for my case, to store the TmpFile :dir as a string instead of a File, or perhaps more generally, add reader support for File types to the pod machinery.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.