boostorg / boostorg/website-v2

Image handling within /site-pages static content/sections

Open
#745 6 comments 0 reactions 1 assignee Assigned to @rbbeeston View on GitHub
Dominant language
HTML
Stars
18
Forks
28
Avg merge
2d 12h
Merged PRs (30d)
77

Description

@sdarwin it's possible this isn't a problem but from what I am seeing (and without access to s3 myself), I feel like it will be so I'm bringing it up now to discuss.

For pages that are created under /site-pages, I'm not sure if there is anything set up to bring over accompanying image files.

ie,

`/site-pages/users` holds an adoc version of https://www.boost.org/users/people.html
`/site-pages/users/images` has all accompanying images
_(https://github.com/cppalliance/site-docs/tree/develop/site-pages/users)_

---
For the Antora docs, images are brought over in the process that builds that out. But for /site-pages, these files are retrieved on-the-fly per request and the route for that is only set up to handle html/adoc files. I don't think we'd want to route image mime-types through Django this way, though I suppose things could be coded to make it a solution - the only thing I don't know is if the image files are even brought over to s3 in the first place. But if that's not a viable solution, the image files would somehow need to be accessible via some kind of virtual folder that would match the URL path that the static page will match to via the Django route (which is dependent on what is set in https://github.com/cppalliance/temp-site/blob/develop/stage_static_config.json).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.