boostorg / boostorg/thread

Serveral tests are flaky because it's assumed that the code is executed in a certain time

Open
#330 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
214
Forks
171
PR merge metrics
No merged PRs in 30d

Description

Serveral tests in thread/test/ are flaky(sometimes pass, sometimes fail) because it assumes that the code is executed in a certain time. When the host is low or overloadded, the test will fail.
Take test_condition_notify_all.cpp as an example. The test assumes that thread1, thread2 and thread3 are finished after notify_all() and sleep 200ms are run. However, it's possible that the thread(s) are not finished after notify_all() and sleep 200ms. The test may need to consider such situation.
https://github.com/boostorg/thread/blob/409c98f8b745e72bc326e93bfaf8a353d94a69b0/test/test_condition_notify_all.cpp#L180-L203

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.