boostorg / boostorg/thread

Most of the platform defintions in include/boost/thread/detail/platform.hpp are unused

Open
#255 1 comment 0 reactions 0 assignees View on GitHub
enhancement PR welcome
Dominant language
C++
Stars
214
Forks
171
PR merge metrics
No merged PRs in 30d

Description

Perhaps it would be a good idea to remove the unused definitions and switch to using Boost.Predef for detection where needed instead?

Example:
```
jking@ubuntu:~/boost/libs/thread$ grep -r AMIGAOS .
./include/boost/thread/detail/platform.hpp:# define BOOST_THREAD_AMIGAOS
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_SOL .
./include/boost/thread/detail/platform.hpp:# define BOOST_THREAD_SOLARIS
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_LINUX .
./include/boost/thread/detail/platform.hpp:# define BOOST_THREAD_LINUX
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_BSD .
./include/boost/thread/detail/platform.hpp:# define BOOST_THREAD_BSD
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.