boostorg / boostorg/test

`BOOST_TEST(p1 == p2)` doesn't always test `p1 == p2`

Open
#340 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
213
Forks
149
Avg merge
18h 17m
Merged PRs (30d)
2

Description

A user of Boost.Test has complained to me that the behavior of `BOOST_TEST(p1 == p2)` when `p1` and `p2` are pointers to `char` is surprising as it silently reinterprets the C++ expression `p1 == p2` to mean something else, namely, `strcmp(p1, p2) == 0`. This is, in this user's opinion, a significant defect that justifies not using Boost.Test. (I don't necessarily agree.)

I suspect that it's much too late now to change this behavior, as who knows how much existing code already relies on it, so I'm not sure what can be done to address this complaint.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.