boostorg / boostorg/statechart

Using std::iterator as base class is deprecated in C++17, causes warnings in MSVC++

Open
#20 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32
Forks
43
PR merge metrics
No merged PRs in 30d

Description

The following code requires an explicit macro to suppress a warning to be defined when compiling with MSVC++:

https://github.com/boostorg/statechart/blob/586445b824c5cf0e7e6ce4ff2df620fda5d0f0d7/include/boost/statechart/state_machine.hpp#L359

Adding _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING solves the problem as a workaround. Other Boost libraries have fixed this issue in the past, for example: https://github.com/boostorg/utility/issues/34

Can provide PR if needed.

Background info:
https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.