boostorg / boostorg/redis

Fail unresponded requests with a different error code

Open
#326 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
282
Forks
49
PR merge metrics
No merged PRs in 30d

Description

We offer `config::cancel_if_unresponded`, which makes a request fail if it was sent to the server but never responded because the connection was severed. There is no way to know whether these requests were processed by the server or not. At the moment, `async_exec` completes with `asio::operation_aborted` for these requests. This makes it impossible for the user to know when this situation happened. We should create a new error code for this situation. See #324 for the discussion.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by examining config::cancel_if_unresponded and the async_exec completion path that currently returns asio::operation_aborted. Read the discussion in #324 before deciding how the new error code should represent an unresponded request. Done means the situation has a distinct error code and the affected behavior is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, redis
Domain
api, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.