boostorg / boostorg/python

stride units in numpy::from_data

Open
#143 3 comments 0 reactions 0 assignees View on GitHub
numpy
Dominant language
C++
Stars
537
Forks
223
Avg merge
11h 22m
Merged PRs (30d)
2

Description

Answering https://github.com/boostorg/python/issues/142, I notice that the `np::from_data` functions require strides to be counted in units of bytes, rather than elements. Is there any particular reason for that choice ? Given that the function also takes a `dtype` argument, which provides a `get_itemsize()` method, it seems plausible (and a bit more convenient) for callers to not have to use `sizeof(value_type)` explicitly.

@TallJimbo, any thoughts ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.