boostorg / boostorg/property_tree

Request json_parser::read_json(boost::filesystem::path const&, ...)

Open
#49 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
65
Forks
97
PR merge metrics
No merged PRs in 30d

Description

There are currently two signatures available:
- `read_json(std::string const&, ...)`
- `read_json(std::basic_istream<...> const&, ...)`

In case of Windows and a file name with non-standard characters I cannot rely on `read_json(std::string const&, ...)`.

I therefore use this workaround:
`boost::filesystem::path const filename(L"Some foreign language file name");`
`boost::filesystem::ifstream ifs(filename);`
`read_json(ifs, ...);`

In case of an error, the exception thrown does not contain the filename and I have to construct a message of my own.

I would like to request these additions:
- `read_json(boost::filesystem::path const&, ...)`
- `read_json(std::wstring const&, ...)`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the existing read_json(std::string const&, ...) and read_json(std::basic_istream<...> const&, ...) entry points, then trace how filenames and errors are handled on Windows. Done means the requested boost::filesystem::path and std::wstring overloads exist and errors retain the filename for non-standard character paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.