boostorg / boostorg/pool

PR #53 introduced a regression into boost pool

Open
#64 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
58
Forks
52
PR merge metrics
No merged PRs in 30d

Description

**TL;DR**: PR #53 seems to be based on a wrong assumption. In fact,`simple_segregated_storage` in its present form is fundamentally uncapable of handling mixed partition sizes, and cannot be "fixed" to allow that handling without a major change of the implementation. The linked-to [Example 4.1](https://theboostcpplibraries.com/boost.pool#ex.pool_01), which was a starting point for the "fix", also looks simply wrong and so does the fix itself.

There is a [new PR here](https://github.com/boostorg/pool/pull/63), which contains further details, including
- the demonstration of the regression (the 1st commit of the new PR),
- the reverting of the code change (2nd commit of the new PR) and
- dropping of the two failing uint tests introduced by PR #53, which are believed to be incorrect.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.