boostorg / boostorg/polygon

polygon::intersect(rectA, rectB, consider_touch) doesn't actually pass consider_touch to the intersection-check

Open
#82 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
70
Forks
75
PR merge metrics
No merged PRs in 30d

Description

function is:
boost::polygon::intersect(T1& a, const T2& b, bool consider_touch = true)

docs on the function:
https://www.boost.org/doc/libs/1_64_0/libs/polygon/doc/gtl_rectangle_concept.htm

bug where the bool isn't passed to the actual intersection-check is:
https://github.com/boostorg/polygon/blob/8ba35b57c1436c4b36f7544aadd78c2b24acc7db/include/boost/polygon/rectangle_concept.hpp#L645

fix:
change
`if(intersects(rectangle, b)) {`
to:
`if(intersects(rectangle, b, consider_touch)) {`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.