connect_op.hpp is missing the start_clean configuration feature.
- Dominant language
- C++
- Stars
- 207
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
void send_connect() {
auto packet = control_packet::of(
no_pid, get_allocator(),
encoders::encode_connect,
_ctx.creds.client_id,
_ctx.creds.username, _ctx.creds.password,
_ctx.keep_alive, false, _ctx.co_props, _ctx.will_msg
);
the "false" is const, should be modified:
void send_connect() {
auto packet = control_packet::of(
no_pid, get_allocator(),
encoders::encode_connect,
_ctx.creds.client_id,
_ctx.creds.username, _ctx.creds.password,
_ctx.keep_alive, _ctx.start_clean, _ctx.co_props, _ctx.will_msg
);
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in connect_op.hpp at send_connect(), where the CONNECT packet is assembled and the hard-coded false value is passed to encoders::encode_connect. Trace the existing start_clean configuration in the connection context, then verify that the packet uses it and run the repository's relevant MQTT connection tests. Done means start_clean controls the generated CONNECT packet instead of a constant.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100