boostorg / boostorg/lockfree

wrong predef flag usage

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
160
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Working on a new boost release I found the lockfree queue stopped working proper and tracked it down: some x86_64 codes are included improperly in a couple of files, namely in boost/lockfree/detail/prefix.hpp and tagged_ptr_ptrcompression.hpp:

#ifdef BOOST_ARCH_X86_64

Should be

#if BOOST_ARCH_X86_64

Otherwise codes on all the other ARCHs will include the wrong piece. I tested the change on powerpc and it works fine so far.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect boost/lockfree/detail/prefix.hpp and tagged_ptr_ptrcompression.hpp, starting with the BOOST_ARCH_X86_64 conditionals described in the issue. Update the conditional usage as specified, then verify the lockfree queue behavior on a non-x86_64 architecture or run the existing lockfree test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.