switch statement case label has only `int` template argument
- Dominant language
- C++
- Stars
- 20
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
Before gcc9, if a template argument is an integral value, no compiler error/warning generated when the specified value is bigger than the integral value MAX.
This leads the following runtime issue:
```
#include
#include
#include
int main() {
using namespace boost;
using namespace boost::lambda;
switch_statement(
_1,
case_statement<2147483648>(std::cout << constant("big")),
default_statement(std::cout << constant("other"))
)(2147483648); // prints 'other'
// static_cast(2147483648) is OK
}
```
This issue prone working can be eliminated in any following way:
- replace case_statement template argument from `int` to `uintmax_t` or `intmax_t` or any bigger than int. This solves that not only `int` parameters can be accepted in later gcc's and clang too.
- switch_statement lambda accepts/casts argument `int`. This solves type safety.
- some other template magic, where at case statement can be set the acceptable integral type, and switch statement recognizes, and uses `common_type` to casts lambda parameter to that.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.