Temp variable uses wrong storage
Open
- Dominant language
- C++
- Stars
- 479
- Forks
- 110
- Avg merge
- 10d 3h
- Merged PRs (30d)
- 5
Description
I think instead of using the array's storage it should use the default storage:
https://github.com/boostorg/json/blob/83c364afaf31b58cfe8b97ab159c406c508f47c9/include/boost/json/impl/array.hpp#L527
Otherwise we are allocating and deallocating in the wrong order, and we are not making correct use of monotonic storage. We should review all functions which require temporary storage (e.g. `object::insert`).
Contributor guide
Assessment
This issue has not been assessed yet.