boostorg / boostorg/interprocess

Security Vulnerability: Security Descriptor NULL DACLs

Open
#107 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
185
Forks
131
PR merge metrics
No merged PRs in 30d

Description

Came across this one while viewing old TRAC bugs. It's pretty recent and I assume the poster didn't know to put it here (and they are anonymous) so... here's the text:

> Our security team has flagged: if(SetSecurityDescriptorDacl(&sd, true, 0, false)) in interprocess\detail\win32_api.hpp as a "high-priority" vulnerability

They then reference some of the text from the [C6248 warning](https://docs.microsoft.com/en-us/cpp/code-quality/c6248?view=msvc-170) which says in part:

>Objects that have null DACLs can have their security descriptors altered by malicious users so that no one has access to the object.
>
>Even if everyone needs access to an object, the object should be secured so that only administrators can alter its security. If only the creator needs access to an object, a DACL should not be set on the object; the system will choose an appropriate default.

Looks like this could be fixed with a little research if someone was available to do the work.

[TRAC 13466](https://svn.boost.org/trac10/ticket/13466)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.