boostorg / boostorg/inspect

Remove min/max macro warning or make it optional

Open
#10 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
9
Forks
29
PR merge metrics
No merged PRs in 30d

Description

The max/min macro issue does not seem to be relevant anymore in modern compilers. I was completely unaware of this in Boost.Histogram and the code works fine on all msvc versions which support C++14. I added the patches to Histogram to get rid of this warning, but now my code became a lot less readable. I am considering to revert this change and propose instead to remove the min/max macro check from the inspection list.

Another solution would be to blacklist checks individually for each library.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.