icl/iterator.hpp and icl/detail/element_iterator.hpp include <boost/config/warning_disable.hpp>
- Dominant language
- C++
- Stars
- 16
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
`icl\iterator.hpp` and `icl\detail\element_iterator.hpp` include ``. This disabled the MSVC warning C4996 without re-enabling it again.
For context: C4996 is MSVC's warning for using deprecated stuff. This means code that uses Boost.Icl will not get warning C4996 which IMO is quite bad. `` even contains the following comment:
```
// IT SHOULD NOT BE INCLUDED BY ANY BOOST HEADER.
//
// YOU SHOULD NOT INCLUDE IT IF YOU CAN REASONABLY FIX THE WARNING.
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect icl/iterator.hpp and icl/detail/element_iterator.hpp, starting with their inclusion of boost/config/warning_disable.hpp and any surrounding warning pragmas. Check the headers with MSVC warning C4996 enabled, and confirm that Boost.Icl no longer suppresses the warning for downstream code without introducing warnings in these headers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100